-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting default position of the simulated robot using ros2_control URDF tag. #100
Enable setting default position of the simulated robot using ros2_control URDF tag. #100
Conversation
Sounds like a good idea and would save some headache with artificial homing, etc. What do you think if all the defaults were collected under a separate tag within the gazebo component? hand-wavy example
alternatively, extending your example
|
I am more on the second approach. Because then we can reuse this in other cases like |
bb285ba
to
5732a48
Compare
gazebo_ros2_control_demos/launch/cart_example_position_initial_position.launch.py
Outdated
Show resolved
Hide resolved
@ahcorde I removed the new files as discussed. Can you please do one more check? After Friday's sync this should be buildable. |
@destogl can you merge with master? |
…trol URDF tag. Signed-off-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Denis Štogl <denis@stogl.de>
6612d8f
to
0f383d7
Compare
Just one last thing @destogl , linters! https://github.com/ros-simulation/gazebo_ros2_control/runs/4966401765?check_suite_focus=true |
bb285ba
to
cd9baf8
Compare
@ahcorde done |
Signed-off-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Denis Štogl <denis@stogl.de>
cd9baf8
to
a9e38c1
Compare
…trol URDF tag. (ros-controls#100) Signed-off-by: Denis Štogl <denis@stogl.de>
Adds support for initial robot's position through ros2_control URDF tag.
This is also compatible with "FakeHardware" and can be used within the driver if needed.
Related PRs are:
The example joint definition looks like (example from UR driver):
This feature is already released in ros2_control, but not synced yet.
I am not sure about one thing: Do we need a separate example for this?