Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unnecessary parameter in demo #68

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Remove Unnecessary parameter in demo #68

merged 1 commit into from
Apr 19, 2021

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 8, 2021

Related with this issue #57

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Remove Unnecessary parameter in demo
8f055ca 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Apr 8, 2021
@ahcorde ahcorde self-assigned this Apr 8, 2021
@ahcorde ahcorde mentioned this pull request Apr 8, 2021
Closed
@j-rivero
Copy link

j-rivero commented Apr 9, 2021

Seems like there is another interface_name in the repo:

gazebo_ros2_control on  ahcorde/unnecessary_param ❯ grep -R interface_name *
gazebo_ros2_control_demos/config/cartpole_controller.yaml:    interface_name: position

do we need to remove it too?

@j-rivero j-rivero self-requested a review April 9, 2021 13:49
@ahcorde
Copy link
Collaborator Author

ahcorde commented Apr 12, 2021

Based on this I think we can remove them

@ahcorde ahcorde merged commit d164ee6 into master Apr 19, 2021
@ahcorde ahcorde deleted the ahcorde/unnecessary_param branch April 19, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @j-rivero