Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galactic: Pass time and period to update function #88

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Galactic: Pass time and period to update function #88

merged 3 commits into from
Oct 26, 2021

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Sep 18, 2021

@bmagyar bmagyar changed the title Pass time and period to update function Galactic: Pass time and period to update function Sep 18, 2021
destogl
destogl approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good as per update on controller manager.

ahcorde
ahcorde requested changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bmagyar, I created a branch for foxy. Do you mind to update gazebo_ros2_control/.github/workflows/ to target galactic?

@bmagyar
Copy link
Member Author

bmagyar commented Sep 21, 2021

sure no problem

@bmagyar bmagyar mentioned this pull request Sep 29, 2021
Closed
@joshnewans joshnewans mentioned this pull request Oct 10, 2021
Open
@bmagyar
Copy link
Member Author

bmagyar commented Oct 15, 2021

@ahcorde could you please kick the CI to retry? The packages should be available from upstream now

ahcorde
ahcorde requested changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to change this line in the gazebo_ros2_control/package.xml

  <exec_depend>joint_state_controller</exec_depend>

with

  <exec_depend>joint_state_broadcaster</exec_depend>

@bmagyar
Copy link
Member Author

bmagyar commented Oct 15, 2021

Done!

@ahcorde
Copy link
Collaborator

ahcorde commented Oct 26, 2021

I will fix CI in other PR

@ahcorde ahcorde merged commit 83089d3 into ros-controls:master Oct 26, 2021
ksotebeer pushed a commit to ksotebeer/gazebo_ros2_control that referenced this pull request Jun 14, 2022
@bmagyar @ksotebeer
Galactic: Pass time and period to update function (ros-controls#88)
98fdf18 
* Pass time and period to update function

* Use Galactic in GH action

* joint_state_broadcaster in town
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmagyar @ahcorde @destogl