-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added testing CI #93
Added testing CI #93
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not wrong, most of the code is the same than in the other action, it would be great to use a composite action for this https://docs.github.com/en/actions/creating-actions/creating-a-composite-action. I left this to your criteria.
Minor comment of the naming, code looks just fine.
.github/workflows/ci.yaml
Outdated
@@ -41,3 +41,39 @@ jobs: | |||
. /opt/ros/galactic/local_setup.sh | |||
colcon test --event-handlers console_direct+ --packages-select gazebo_ros2_control gazebo_ros2_control_demos | |||
colcon test-result | |||
build_prerelease: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When looking into the CI matrix the prelease term distracted me, how about changing it to build_testing to match the change in the building context when using testing repo?
Another question: the github actions seems to be using galactic, but this PR is targeted to master branch (which I assume that is probably Rolling). Is this expected? |
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
galactic and rolling are the same at this point |
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
* Added prerelease CI Signed-off-by: ahcorde <ahcorde@gmail.com> * Change name of the job Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> * Migrate to component lifecycle (ros-controls#94) Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Signed-off-by: ahcorde ahcorde@gmail.com