Pass ROS time instead of SYSTEM time to update function #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the gazebo plugin (especially since it's gazebo :D ) should use ROS time to support simulation time |
bmagyar
approved these changes
Nov 27, 2021
|
@ahcorde I think this should be merged |
ahcorde
approved these changes
Nov 27, 2021
|
should we need to backport this to foxy ? |
|
No, thank you. Passing time in is not part of the API in foxy.
…On Sat, 27 Nov 2021, 09:23 Alejandro Hernández Cordero, < ***@***.***> wrote:
should we need to backport this to foxy ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA24PYITHQ7BONKF3IXI6PTUOCPSTANCNFSM5HRELG2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
ksotebeer
pushed a commit
to ksotebeer/gazebo_ros2_control
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ros-controls/ros2_controllers#253
I haven't tested it with all the available controllers though.