Fix setting initial values if command interfaces are not defined. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
approved these changes
Feb 18, 2022
|
We are migrating |
|
Fine for me. |
|
@ahcorde Will this PR find its way into the humble release? Would be great! |
bmagyar
approved these changes
May 19, 2022
|
@destogl do you mind to merge this with |
friendly ping |
destogl
force-pushed
the
fix-initial-values
branch
from
eca44b9
to
fcd82bf
Compare
|
@ahcorde sorry for the log delay. I have just rebased this to master and it should be mergable now. |
ahcorde
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #108.
The reason for the issue is that if the command interface does not exist, the initial value is never propagated to the simulator.