Upgrade to Node.js v16 (#778)

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>

.github/workflows/build-and-test.sh

@@ -3,6 +3,18 @@ set -euxo pipefail
 
 npm install -g codecov
 
+# When running inside a Docker container, by default, we're root and all files belond to root.
+# However, calling the npm scripts (build, etc.) with 'npm run ...' runs the commands as user
+# ID=1001, which means we can't open or write to any files. Therefore, if we're in Docker, chown
+# everything under /__w (which is the workspace directory on the host: /home/runner/work) to user
+# ID=1001. See:
+# * https://github.com/ros-tooling/setup-ros/pull/521
+# * https://github.com/npm/cli/issues/4589
+docker_workdir="/__w"
+if [ -d "${docker_workdir}" ]; then
+  chown -R 1001:1001 "${docker_workdir}"
+fi
+
 npm ci
 npm run build
 npm test

.github/workflows/pr.yml

@@ -14,6 +14,6 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3.6.0
         with:
-          node-version: "12.x"
+          node-version: "16.x"
       - run: npm install && npm run lint
       - run: npm run build && git diff --exit-code

.github/workflows/test.yml

@@ -55,7 +55,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3.6.0
         with:
-          node-version: "12.x"
+          node-version: "16.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ./
         id: action-ros-ci
@@ -82,7 +82,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3.6.0
         with:
-          node-version: "12.x"
+          node-version: "16.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ros-tooling/setup-ros@master
         with:
@@ -105,7 +105,7 @@ jobs:
     needs: pre_condition
     steps:
       - uses: actions/checkout@v3
-      - uses: ros-tooling/setup-ros@v0.3
+      - uses: ros-tooling/setup-ros@master
         with:
           required-ros-distributions: foxy
       - uses: ./
@@ -120,7 +120,7 @@ jobs:
     needs: pre_condition
     steps:
       - uses: actions/checkout@v3
-      - uses: ros-tooling/setup-ros@v0.3
+      - uses: ros-tooling/setup-ros@master
         with:
           required-ros-distributions: foxy
       # Skip installing test_depend dependency and verifies it isn't installed.
@@ -155,7 +155,7 @@ jobs:
     if: ${{ !github.event.repository.fork && !github.event.pull_request.head.repo.fork }}
     steps:
       - uses: actions/checkout@v3
-      - uses: ros-tooling/setup-ros@v0.3
+      - uses: ros-tooling/setup-ros@master
         with:
           required-ros-distributions: foxy
       - uses: ./
@@ -199,7 +199,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3.6.0
         with:
-          node-version: "12.x"
+          node-version: "16.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ./
         name: "Test rosdep installs from correct distro"
@@ -245,9 +245,9 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3.6.0
         with:
-          node-version: "12.x"
+          node-version: "16.x"
       - run: .github/workflows/build-and-test.sh
-      - uses: ros-tooling/setup-ros@v0.3
+      - uses: ros-tooling/setup-ros@master
       - uses: ./
         id: test_single_package
         name: "Test single package, default options"
@@ -427,9 +427,9 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3.6.0
         with:
-          node-version: "12.x"
+          node-version: "16.x"
       - run: .github/workflows/build-and-test.sh
-      - uses: ros-tooling/setup-ros@v0.3
+      - uses: ros-tooling/setup-ros@master
       - uses: ./
         id: test_single_package
         name: "Test single package, default options"

DEVELOPING.md

@@ -4,7 +4,7 @@
 
 Install [Node.js](https://nodejs.org/en/download/).
 
-We are currently using Node.js v12.
+We are currently using Node.js v16.
 
 ## Build and test
 

action.yml

@@ -89,5 +89,5 @@ outputs:
     description: |
       root directory name of the ROS workspace created for this CI code.
 runs:
-  using: "node12"
+  using: "node16"
   main: "dist/index.js"