Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of using setup-ros for the internal tests, use the setup-ros-docker images, which should be a lot faster than installing all of desktop #496

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

emersonknapp
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #496 (ce6ed18) into master (c2e4245) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   36.05%   36.05%           
=======================================
  Files           1        1           
  Lines         147      147           
  Branches       29       29           
=======================================
  Hits           53       53           
  Misses         94       94           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e4245...ce6ed18. Read the comment docs.

…docker images, which should be a lot faster than installing all of desktop

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/use-premade-images-for-tests branch from ae92e03 to ce6ed18 Compare January 6, 2021 02:10
@emersonknapp emersonknapp marked this pull request as ready for review January 6, 2021 17:13
@emersonknapp emersonknapp requested a review from a team as a code owner January 6, 2021 17:13
@emersonknapp emersonknapp requested review from Karsten1987 and prajakta-gokhale and removed request for a team January 6, 2021 17:13
@emersonknapp emersonknapp merged commit 3bef0fb into master Jan 6, 2021
@emersonknapp emersonknapp deleted the emersonknapp/use-premade-images-for-tests branch January 6, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants