Enforce prettier code styling #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
requested review from
Karsten1987 and
prajakta-gokhale
and removed request for
a team
emersonknapp
force-pushed
the
emersonknapp/enforce-linter
branch
2 times, most recently
from
92279c4
to
8a1d4f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 36.00% 35.76% -0.24%
==========================================
Files 1 1
Lines 150 151 +1
Branches 29 29
==========================================
Hits 54 54
- Misses 96 97 +1
Continue to review full report at Codecov.
|
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/enforce-linter
branch
from
8a1d4f2
to
a9c1268
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
christophebedard
approved these changes
Feb 12, 2021
zmichaels11
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce linter style in the tests and note the autoformatting command in DEVELOPING.md.
Helps avoid the "please don't include formatting changes in functional PRs" comments. I think some people's editors, or maybe some pre-commit hook that I don't have is doing it for other developers.
Helps address comments on #523 and #524
Lint failure in first commit check https://github.com/ros-tooling/action-ros-ci/pull/535/checks?check_run_id=1884593227