Don't run scheduled jobs on forks

[christophebedard]

I often enable actions on my fork to open PRs (on my own fork) to test things out with CI. There's no real reason to run hourly scheduled jobs on forks.

I tried these and they didn't work:

• if: ${{ (github.event_name != 'schedule') || (github.event_name == 'schedule' && !github.event.repository.fork) }}
• if: ${{ (github.event_name != 'schedule') || (github.event_name == 'schedule' && github.event.repository.fork == false) }}

[christophebedard]

Well this doesn't seem to work. I'll try something else.

[codecov]

Codecov Report

Merging #584 (179c4b8) into master (c5b726b) will decrease coverage by 0.93%.
The diff coverage is n/a.

❗ Current head 179c4b8 differs from pull request most recent head d74cd11. Consider uploading reports for the commit d74cd11 to get more accurate results

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   39.90%   38.96%   -0.94%     
==========================================
  Files           2        2              
  Lines         213      213              
  Branches       39       39              
==========================================
- Hits           85       83       -2     
- Misses        128      130       +2     

Impacted Files	Coverage Δ
src/action-ros-ci.ts	29.34% <0.00%> (-1.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b726b...d74cd11. Read the comment docs.

[christophebedard]

It works now.

[emersonknapp]

Is there any way that we can reduce the duplication?

[christophebedard]

Is there any way that we can reduce the duplication?

I'll try defaults.if.

[christophebedard]

I'll try defaults.if.

It's not valid apparently:

defaults:
  # Don't run scheduled jobs on forks
  if: ${{ (github.event_name != 'schedule') || (github.event_name == 'schedule' && github.repository == 'ros-tooling/action-ros-ci') }}

The workflow is not valid. .github/workflows/test.yml (Line: 14, Col: 3): Unexpected value 'if'

I can think of two alternatives, but they all require some level of duplication and are a bit more complex, so I'm not sure if it's worth it:

1. have a top-level env: using the big condition, and have a simple if: for each job (not sure if that works though)
2. define an empty/trivial job (which uses the big if: condition) and have all other jobs depend on it using needs: so that they only run if the first job runs

I'll try option 2.

Note that YAML anchors are unfortunately not supported: https://github.community/t/support-for-yaml-anchors/16128/61

[christophebedard]

Option 2 works nicely: https://github.com/christophebedard/action-ros-ci/actions/runs/662189751

[emersonknapp]

Thanks for figuring out this way to do it - it looks pretty clean to me

[dhimmel]

if: ${{ (github.event_name != 'schedule') || (github.event_name == 'schedule' && !github.event.repository.fork) }}... Well this doesn't seem to work. I'll try something else.

Noting that the reason this didn't work is because the github.event.repository.fork context is not set for scheduled jobs.