Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add galactic to valid distros list to support binary installs #642

Merged
merged 7 commits into from
May 12, 2021

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented May 7, 2021

Part of #640

This allows users to use target-ros2-distro: galactic (to use a Galactic binary installation). Note that users must currently use the testing repository to get Galactic binaries. See ros-tooling/setup-ros#387

Users can still build Galactic from source until then.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard requested a review from a team as a code owner May 7, 2021 12:42
@christophebedard christophebedard self-assigned this May 7, 2021
@christophebedard christophebedard requested review from emersonknapp and zmichaels11 and removed request for a team May 7, 2021 12:42
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #642 (b3640ab) into master (00a16c1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b3640ab differs from pull request most recent head e63fded. Consider uploading reports for the commit e63fded to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   39.20%   39.20%           
=======================================
  Files           2        2           
  Lines         227      227           
  Branches       44       44           
=======================================
  Hits           89       89           
  Misses        138      138           
Impacted Files Coverage Δ
src/action-ros-ci.ts 30.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b06847...e63fded. Read the comment docs.

@christophebedard christophebedard changed the title Add galactic to list of valid distros to support binary installations Add galactic to valid distros list to support binary installs May 7, 2021
@christophebedard christophebedard enabled auto-merge (squash) May 7, 2021 19:00
@emersonknapp emersonknapp merged commit bc8e741 into master May 12, 2021
@emersonknapp emersonknapp deleted the christophebedard/support-galactic-testing branch May 12, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants