Update distros in tests

[christophebedard]

This updates the tests to remove Dashing & Eloquent from the config matrices and add Galactic instead.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

[codecov]

Codecov Report

Merging #669 (aa27337) into master (2b22e09) will decrease coverage by 0.86%.
The diff coverage is n/a.

❗ Current head aa27337 differs from pull request most recent head 16734ce. Consider uploading reports for the commit 16734ce to get more accurate results

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
- Coverage   38.52%   37.66%   -0.87%     
==========================================
  Files           2        2              
  Lines         231      231              
  Branches       46       46              
==========================================
- Hits           89       87       -2     
- Misses        142      144       +2     

Impacted Files	Coverage Δ
src/action-ros-ci.ts	28.71% <0.00%> (-1.00%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b22e09...16734ce. Read the comment docs.

[emersonknapp]

Looks good. I don't want to remove the ability to run against EOL distros, but I agree there is no reason to continue testing them.

[christophebedard]

Looks good. I don't want to remove the ability to run against EOL distros, but I agree there is no reason to continue testing them.

yeah I initially removed them from the valid distros list, but then thought that it wasn't really necessary. setup-ros does say it only supports non-EOL source builds, though, but it currently doesn't complain for Dashing, Eloquent, Kinetic, and Lunar. Should we change the wording to say something like "you can try and we don't actively prevent that, but we don't officially support it either"

[christophebedard]

@emersonknapp I think this is blocking auto-merging. They're remnants of the old jobs? Or are they tied to some config that makes them Required?

[emersonknapp]

Ah yes - this is in repository settings - I've removed the requirement for the Eloquent and Dashing tests. I will add a requirement for Galactic

[christophebedard]

Ah yes - this is in repository settings - I've removed the requirement for the Eloquent and Dashing tests. I will add a requirement for Galactic

awesome thank you 😃