Add 'skip-tests' option #685
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
requested review from
emersonknapp and
zmichaels11
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 50.00% 48.55% -1.45%
==========================================
Files 2 2
Lines 238 243 +5
Branches 52 53 +1
==========================================
- Hits 119 118 -1
- Misses 119 125 +6
Continue to review full report at Codecov.
|
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
christophebedard/add-skip-tests-option
branch
from
51a340c
to
efe07dd
Compare
| ...options, | ||
| ignoreReturnCode: true, | ||
| }); | ||
| if (!skipTests) { |
There was a problem hiding this comment.
This change is fine - but a nitpick: the indentation of this entire block suggests that it could be a separate function.
There was a problem hiding this comment.
done in eacf631
Other stuff should probably be split out at some point too.
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Closes #684
This adds a
skip-testsoption. When set totrue, it skips tests and coverage data processing.When the option is enabled, the action prints "Skipping tests" right after
colcon build.Signed-off-by: Christophe Bedard bedard.christophe@gmail.com