Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Galactic since it is EOL #790

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

christophebedard
Copy link
Member

Support for Galactic ended after November 2022.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

@christophebedard christophebedard self-assigned this Jan 29, 2023
@christophebedard christophebedard requested a review from a team as a code owner January 29, 2023 17:53
@christophebedard christophebedard requested review from emersonknapp and jhdcs and removed request for a team January 29, 2023 17:53
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 49.44% // Head: 49.44% // No change to project coverage 👍

Coverage data is based on head (cc3d1b8) compared to base (cc3d1b8).
Patch has no changes to coverable lines.

❗ Current head cc3d1b8 differs from pull request most recent head 3bfb3c2. Consider uploading reports for the commit 3bfb3c2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files           2        2           
  Lines         271      271           
  Branches       72       72           
=======================================
  Hits          134      134           
  Misses        137      137           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christophebedard
Copy link
Member Author

CI failures are due to old versions of ament_lint packages being used (ament/ament_lint#428). I'll bump the version in a separate PR.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Users continue to build EOL Galactic apps, as long as they keep pinned to an older version of action-ros-ci, correct?

@christophebedard
Copy link
Member Author

christophebedard commented Jan 30, 2023

Yes and no. I haven't removed "galactic" from the list of accepted distros (because I/we didn't remove the other EOL distros from that list), so it might work fine for a little while more. No real need to pin an older version.

We don't explicitly forbid users from selecting Galactic, but we just don't support it officially going forward.

@christophebedard christophebedard merged commit f3f9f5a into master Jan 30, 2023
@christophebedard christophebedard deleted the christophebedard/remove-galactic branch January 30, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants