Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use console_direct event handler for colcon test #827

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Jul 15, 2023

action-ros-ci currently uses console_cohesion+ for both colcon build and colcon test. ci.ros2.org uses console_cohesion+ for colcon build (prints output once package is done being processed) and console_direct+ for colcon test (prints output directly).

Users can override the default event handler selected by action-ros-ci using the extra-colcon-args input (since those extra args are added on to the end of the colcon test call, and CLI arguments override any previous argument), but I think it makes sense to change the default event handler for colcon test to console_direct+.

@christophebedard christophebedard requested a review from a team as a code owner July 15, 2023 19:11
@christophebedard christophebedard self-assigned this Jul 15, 2023
@christophebedard christophebedard requested review from MichaelOrlov and removed request for a team July 15, 2023 19:11
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9e8081) 47.70% compared to head (036551e) 47.70%.

❗ Current head 036551e differs from pull request most recent head 5127e87. Consider uploading reports for the commit 5127e87 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   47.70%   47.70%           
=======================================
  Files           2        2           
  Lines         283      283           
  Branches       77       77           
=======================================
  Hits          135      135           
  Misses        148      148           
Impacted Files Coverage Δ
src/action-ros-ci.ts 41.73% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard force-pushed the christophebedard/colcon-test-use-event-handle-console-direct branch from 683be80 to 5127e87 Compare July 18, 2023 16:25
@christophebedard christophebedard enabled auto-merge (squash) July 18, 2023 16:28
@christophebedard christophebedard merged commit 202d93a into master Jul 18, 2023
27 of 28 checks passed
@christophebedard christophebedard deleted the christophebedard/colcon-test-use-event-handle-console-direct branch July 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants