Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-symlink-install option #859

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

christophebedard
Copy link
Member

Closes #858

@christophebedard christophebedard self-assigned this Apr 12, 2024
@christophebedard christophebedard requested a review from a team as a code owner April 12, 2024 00:34
@christophebedard christophebedard requested review from emersonknapp and jhdcs and removed request for a team April 12, 2024 00:34
@christophebedard
Copy link
Member Author

@antbono could you give this a try? By using ros-tooling/action-ros-ci@christophebedard/option-symlink-install and the new no-symlink-install option: https://github.com/ros-tooling/action-ros-ci/blob/christophebedard/option-symlink-install/README.md#Do-not-use---symlink-install-when-building

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard force-pushed the christophebedard/option-symlink-install branch from 3d124c8 to 56b55ca Compare April 12, 2024 00:36
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.70%. Comparing base (3dfca1f) to head (56b55ca).

Files Patch % Lines
src/action-ros-ci.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   45.81%   44.70%   -1.12%     
==========================================
  Files           2        2              
  Lines         299      302       +3     
  Branches       80       81       +1     
==========================================
- Hits          137      135       -2     
- Misses        162      167       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antbono
Copy link

antbono commented Apr 12, 2024

@christophebedard thank you so much for this feature in so little time!

I really appreciated it. I am sorry to not have been able to do a PR by myself.

I have just tested and it works fine!

@christophebedard
Copy link
Member Author

Thanks for confirming!

@christophebedard christophebedard merged commit 769c644 into master Apr 12, 2024
21 of 31 checks passed
@christophebedard christophebedard deleted the christophebedard/option-symlink-install branch April 12, 2024 22:10
@christophebedard
Copy link
Member Author

I released this as 0.3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to choose the option "--symlink-install"
2 participants