Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run apt-get update before trying to install linter packages #227

Merged
merged 2 commits into from
Jan 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
test_setup_ros:
runs-on: ubuntu-latest
container:
image: ubuntu:bionic
image: ubuntu:focal
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -25,7 +25,7 @@ jobs:
with:
node-version: '12.x'
- run: .github/workflows/build-and-test.sh
- uses: ros-tooling/setup-ros@0.0.26
- uses: ros-tooling/setup-ros@v0.1
- uses: actions/checkout@v2
with:
repository: ament/ament_lint
Expand All @@ -46,7 +46,7 @@ jobs:
test_setup_ros_docker:
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-focal-latest
options: -u root # setup-node requires root access
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ inputs:
description: 'ROS 2 Linter'
required: false
distribution:
default: 'eloquent'
default: 'rolling'
description: 'ROS 2 Distribution to install the lint tool from'
required: false
package-name:
Expand Down
1 change: 1 addition & 0 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,7 @@ function run() {
const rosDistribution = core.getInput("distribution");
const rosWorkspaceDir = core.getInput("workspace-directory") || process.env.GITHUB_WORKSPACE;
yield exec.exec("rosdep", ["update"]);
yield exec.exec("sudo", ["apt-get", "update"]);
yield runAptGetInstall([`ros-${rosDistribution}-ament-${linterToolDashes}`]);
const options = {
cwd: rosWorkspaceDir
Expand Down
1 change: 1 addition & 0 deletions src/action-ros-lint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export async function run() {

await exec.exec("rosdep", ["update"]);

await exec.exec("sudo", ["apt-get", "update"]);
await runAptGetInstall([`ros-${rosDistribution}-ament-${linterToolDashes}`]);

const options = {
Expand Down