Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setup-ros to 0.0.20 #10

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

dabonnie
Copy link
Contributor

Signed-off-by: Devin Bonnie dbbonnie@amazon.com

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   25.40%   25.40%           
=======================================
  Files          26       26           
  Lines         807      807           
  Branches      188      188           
=======================================
  Hits          205      205           
  Misses        435      435           
  Partials      167      167           
Flag Coverage Δ
#unittests 25.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741dce3...1625f44. Read the comment docs.

@piraka9011
Copy link

ModuleNotFoundError: No module named 'numpy'

@thomas-moulard
Copy link
Member

thomas-moulard commented Apr 24, 2020

Re-running the build, should work this time. (we should not merge this with @master, let's re-release setup-ros, update this PR and merge if this works)

@thomas-moulard
Copy link
Member

It works 🎉

0.0.20 is also installing numpy which currently
prevents the CI runs from succeeding.

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Thomas Moulard <tmoulard@amazon.com>
@thomas-moulard thomas-moulard changed the title Use setup-ros master Bump setup-ros to 0.0.20 Apr 24, 2020
@thomas-moulard thomas-moulard marked this pull request as ready for review April 24, 2020 01:41
@dabonnie dabonnie mentioned this pull request Apr 24, 2020
@thomas-moulard thomas-moulard merged commit fa10801 into master Apr 24, 2020
@thomas-moulard thomas-moulard deleted the dabonnie/use-setup-ros-master branch April 24, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants