Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install includes to include/${PROJECT_NAME} #122

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 25, 2022

Also, use SKIP_INSTALL on interfaces generated just for testing to prevent those headers from being installed.

Part of ros2/ros2#1150 - this avoids include directory search order issues when overriding this package.

Also, use SKIP_INSTALL on interfaces generated just for testing

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested a review from a team as a code owner January 25, 2022 23:03
@sloretz sloretz requested review from emersonknapp and jhdcs and removed request for a team January 25, 2022 23:03
Copy link

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Idle thought/question: Is there any way we can set up automatic CI testing for this? Just in case of future regressions (though CMake doesn't tend to change often, so that might never happen. Knock on wood)

@sloretz
Copy link
Contributor Author

sloretz commented Jan 27, 2022

Idle thought/question: Is there any way we can set up automatic CI testing for this? Just in case of future regressions (though CMake doesn't tend to change often, so that might never happen. Knock on wood)

Automatic CI tests for the test headers being installed, or to make sure all includes are installed to an extra project name directory, or something else? I don't have any good ideas for how to test the first two, but CI with downstream packages included makes sure the include search directory exported by CMake matches the one installed.

@sloretz
Copy link
Contributor Author

sloretz commented Jan 27, 2022

CI (repos file build: --packages-up-to libstatistics_collector rclcpp test: --packages-select libstatistics_collector)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit e19e33c into ros-tooling:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants