Remove unnecessary build dependency on std_msgs. #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested review from
Karsten1987 and
jhdcs
and removed request for
a team
|
Full CI, with this PR and ros2/rosidl#708:
|
Instead, make it a test_depend, which is much more appropriate.
We also make it so that we don't export the 'std_msgs' dependency
to downstream packages, as only our tests depend on it.
While we were in here cleaning things up, make a couple of other
minor fixes:
1. Remove an unnecessary #include to rcutils.
2. Remove a duplicated call to ament_cmake; that is already
a transitive dependency via ament_cmake_ros.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
SKIP_GROUP_MEMBERSHIP_CHECK isn't needed when SKIP_INSTALL is specified, and also we tied skipping dependency export to SKIP_INSTALL. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/remove-std-msgs-dep
branch
from
f743913
to
4a08bc8
Compare
|
CI:
|
|
CI is green, and while I could merge this one in now, I'm actually going to wait for ros2/rosidl#708 to be approved before doing that. |
|
All right, the rosidl PR has been merged, so I'll go ahead and merge this one as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, make it a test_depend, which is much more appropriate. We also make it so that we don't export the 'std_msgs' dependency to downstream packages, as only our tests depend on it.
While we were in here cleaning things up, make a couple of other minor fixes:
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that this depends on ros2/rosidl#708 to fully work.
Fixes #144