Run lint worflow on Docker #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Moulard <tmoulard@amazon.com>
zmichaels11
approved these changes
Apr 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 25.40% 25.40%
=======================================
Files 26 26
Lines 807 807
Branches 188 188
=======================================
Hits 205 205
Misses 435 435
Partials 167 167
Continue to review full report at Codecov.
|
| runs-on: ubuntu-18.04 | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest |
There was a problem hiding this comment.
For master branch, do we need a "foxy" or "master" version of this base image?
There was a problem hiding this comment.
The lint workflow (even before this commit) is relying on prebuilt binaries from APT packages, so we don't have a way to test master. As far as Foxy is concerned, yes, we should mass-update to Focal/Foxy once we have stable APT packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.