Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add void annotation #194

Merged
merged 1 commit into from
May 9, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 8, 2024

This PR surpresses compiler warning in a package which uses rclcpp_compoent.

Starting >>> traffic_light_visualization
--- stderr: traffic_light_visualization                               
In file included from /opt/ros/jazzy/include/rclcpp/rclcpp/topic_statistics/subscription_topic_statistics.hpp:27,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/subscription.hpp:50,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/any_executable.hpp:25,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/memory_strategy.hpp:25,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/memory_strategies.hpp:18,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/executor_options.hpp:20,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/executor.hpp:38,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/executors.hpp:21,
                 from /opt/ros/jazzy/include/rclcpp/rclcpp/rclcpp.hpp:172,
                 from /home/daisuke/workspace/autoware/build/traffic_light_visualization/rclcpp_components/node_main_traffic_light_visualization_node.cpp:21:
/opt/ros/jazzy/include/libstatistics_collector/libstatistics_collector/topic_statistics_collector/received_message_period.hpp: In member function ‘virtual void libstatistics_collector::topic_statistics_collector::ReceivedMessagePeriodCollector<rmw_message_info_s, void>::OnMessageReceived(const rmw_message_info_t&, rcl_time_point_value_t)’:
/opt/ros/jazzy/include/libstatistics_collector/libstatistics_collector/topic_statistics_collector/received_message_period.hpp:175:32: error: unused parameter ‘message_info’ [-Werror=unused-parameter]
  175 |     const rmw_message_info_t & message_info,

@wep21 wep21 requested a review from a team as a code owner May 8, 2024 06:49
@wep21 wep21 requested review from emersonknapp and jhdcs and removed request for a team May 8, 2024 06:49
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (rolling@685c77e). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             rolling     #194   +/-   ##
==========================================
  Coverage           ?   24.35%           
==========================================
  Files              ?       67           
  Lines              ?     5382           
  Branches           ?      662           
==========================================
  Hits               ?     1311           
  Misses             ?     3976           
  Partials           ?       95           
Flag Coverage Δ
unittests 24.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me with green CI.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

The failing CI should have nothing to do with this PR, and was instead a regression elsewhere. That should be fixed now, so here is another try at CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

CI looks good here, so going ahead and merging. Thanks for the PR.

@clalancette clalancette merged commit 784f746 into ros-tooling:rolling May 9, 2024
14 checks passed
@wep21 wep21 deleted the add-void-annotation branch May 9, 2024 16:06
wep21 added a commit to wep21/libstatistics_collector that referenced this pull request May 18, 2024
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
wep21 added a commit to wep21/libstatistics_collector that referenced this pull request May 24, 2024
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
christophebedard pushed a commit that referenced this pull request May 24, 2024
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants