Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: measured values after the decimal point are truncated #79 #80

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

hsgwa
Copy link
Contributor

@hsgwa hsgwa commented Jan 20, 2021

Closes #79
Signed-off-by: hsgwa hasegawa@isp.co.jp

@hsgwa hsgwa requested a review from a team as a code owner January 20, 2021 12:31
@hsgwa hsgwa requested review from thomas-moulard and lucashan and removed request for a team January 20, 2021 12:31
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #80 (c15f041) into master (21d6664) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   24.75%   24.75%           
=======================================
  Files          27       27           
  Lines         820      820           
  Branches      185      185           
=======================================
  Hits          203      203           
  Misses        454      454           
  Partials      163      163           
Flag Coverage Δ
unittests 24.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...opic_statistics_collector/received_message_age.hpp
...rc/libstatistics_collector/collector/collector.cpp
...c_statistics_collector/received_message_period.hpp
...rage_statistics/test_moving_average_statistics.cpp
...ector/moving_average_statistics/moving_average.hpp
...tatistics_collector/topic_statistics_collector.hpp
...istics_collector/test/collector/test_collector.cpp
...statistics_collector/test_received_message_age.cpp
...tistics_collector/test_received_message_period.cpp
...tics_collector/moving_average_statistics/types.cpp
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d6664...c15f041. Read the comment docs.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - thanks for the patch! The linters are failing for an unrelated reason - fixing it in #81 and then we can update this PR, run CI and go ahead

@emersonknapp
Copy link
Contributor

Gist: https://gist.githubusercontent.com/emersonknapp/29e983ca6d9dd0746d4077bae8385843/raw/957466cc7a89fdba2f1afde51632a0ad4fb7ad12/ros2.repos
BUILD args: --packages-up-to libstatistics_collector
TEST args: --packages-select libstatistics_collector
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/7488

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 98381bc into ros-tooling:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The measured values after the decimal point are truncated.
2 participants