-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for installing ROS1/ROS2 releases #21
Comments
Duplicate? #20 |
ROS1 != ros1_bridge |
Oh, I was assuming that |
Unfortunately, |
Instead, should there be an action called "setup_ros1"? steps:
- uses: ros-tooling/setup-ros2
- uses: ros-tooling/setup-ros1
- uses: ros-tooling/action-ros2-ci |
Need to check, but I think that there is too much overlap between ROS1/ROS2 install to justify a different workflow, but I may be wrong (?). |
This has been fixed by #30 |
Description
rosdep
can properly pull dependencies,action-ros2-ci
rosdep
run may provide this to us "for free".As a GH action user, I want to install a specific version of ROS1 using OSRF Debian packages.
This should be implemented by executing commands on the host machines, not through Docker (to keep the ROS1/ROS2 codepath similar for now, this can be re-evaluated down the road).
This requires splitting the current logic into multiple modules to prevent code duplication.
The API could look like this:
Allowed values for
version
be:ros-melodic, ros-source, ros2-dashing, ros2-source
, etc.We would default to
ros2-source
to avoid breaking compatibility.Test Plan
Documentation Plan
Release Plan
setup-ros2
should be re-releasedAcceptance Criteria
Once all above items are checked, this story can be moved to done.
References
The text was updated successfully, but these errors were encountered: