Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Measure linux cpu active percentage #11

Merged
merged 8 commits into from Nov 14, 2019
Merged

Measure linux cpu active percentage #11

merged 8 commits into from Nov 14, 2019

Conversation

dabonnie
Copy link
Contributor

This PR adds a node which periodically measures the system active CPU %. This can be manually verified, on a linux system, with the example main function. Here's sample output with a window reset:

[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.551427, min=1.282051, max=47.272727, std_dev=9.692852, count=54
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 9.859155
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.593386, min=1.282051, max=47.272727, std_dev=9.609279, count=55
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 2.631579
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.504782, min=1.282051, max=47.272727, std_dev=9.545739, count=56
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 16.666667
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.665517, min=1.282051, max=47.272727, std_dev=9.537783, count=57
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 1.298701
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.555745, min=1.282051, max=47.272727, std_dev=9.491455, count=58
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 11.111111
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.616005, min=1.282051, max=47.272727, std_dev=9.421859, count=59
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 13.043478
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.706463, min=1.282051, max=47.272727, std_dev=9.368814, count=60
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 15.942029
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=15.942029, min=15.942029, max=15.942029, std_dev=0.000000, count=1
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 5.194805
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=10.568417, min=5.194805, max=15.942029, std_dev=5.373612, count=2
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 3.846154
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=8.327663, min=3.846154, max=15.942029, std_dev=5.412248, count=3
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 2.564103
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=6.886773, min=2.564103, max=15.942029, std_dev=5.310161, count=4
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 3.846154
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=6.278649, min=2.564103, max=15.942029, std_dev=4.902806, count=5
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 17.910448
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=8.217282, min=2.564103, max=17.910448, std_dev=6.230791, count=6
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 1.298701
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=7.228913, min=1.298701, max=17.910448, std_dev=6.256027, count=7
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 2.564103
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=6.645812, min=1.298701, max=17.910448, std_dev=6.051917, count=8
[DEBUG] [linuxCpuCollector]: performPeriodicMeasurement: 2.564103
[DEBUG] [linuxCpuCollector]: name=linuxCpuCollector, measurement_period=1000ms, publishing_topic=not_publishing_yet, publish_period=60000ms, clear_measurements_on_publish_=1, started=true, avg=6.192289, min=1.298701, max=17.910448, std_dev=5.848217, count=9

zmichaels11
zmichaels11 reviewed Nov 13, 2019
View reviewed changes
system_metrics_collector/src/moving_average_statistics/moving_average.hpp Outdated Show resolved Hide resolved
system_metrics_collector/src/moving_average_statistics/types.hpp Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/cpu_data.hpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/cpu_data.hpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_cpu_measurement_node.cpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_cpu_measurement_node.cpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_cpu_measurement_node.hpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/main.cpp Outdated Show resolved Hide resolved
system_metrics_collector/test/system_metrics_collector/test_linux_cpu_measurement.cpp Outdated Show resolved Hide resolved
thomas-moulard
thomas-moulard reviewed Nov 13, 2019
View reviewed changes
system_metrics_collector/CMakeLists.txt Outdated Show resolved Hide resolved
system_metrics_collector/CMakeLists.txt Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/collector.cpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/cpu_data.hpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/cpu_data.hpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/cpu_data.hpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_cpu_measurement_node.cpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_cpu_measurement_node.cpp Outdated Show resolved Hide resolved
system_metrics_collector/test/system_metrics_collector/test_linux_cpu_measurement.cpp Outdated Show resolved Hide resolved
system_metrics_collector/src/system_metrics_collector/main.cpp Show resolved Hide resolved
@thomas-moulard
Copy link
Member

This PR is in great shape for a first pass, let's chat tomorrow to see how to solve the remaining issues!

@dabonnie dabonnie merged commit 16fe1f0 into master Nov 14, 2019
@dabonnie dabonnie deleted the measure-linux-cpu branch November 14, 2019 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zmichaels11 zmichaels11 zmichaels11 approved these changes

@thomas-moulard thomas-moulard Awaiting requested review from thomas-moulard

@piraka9011 piraka9011 Awaiting requested review from piraka9011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dabonnie @thomas-moulard @zmichaels11 @piraka9011