This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example output from running the main (with the system cpu and memory nodes inactive):
|
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 41.88% 42.04% +0.16%
==========================================
Files 23 26 +3
Lines 819 880 +61
Branches 475 506 +31
==========================================
+ Hits 343 370 +27
- Misses 42 50 +8
- Partials 434 460 +26
Continue to review full report at Codecov.
|
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.cpp
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/utilities.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.hpp
Show resolved
Hide resolved
Review changes WIP, not all have been addressed. |
dabonnie
force-pushed
the
process-memory-measurement
branch
from
December 10, 2019 00:10
903386d
to
9ea2924
Compare
zmichaels11
approved these changes
Dec 10, 2019
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/linux_process_memory_measurement_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Add test file Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
dabonnie
force-pushed
the
process-memory-measurement
branch
from
December 10, 2019 18:12
9ea2924
to
2102fc4
Compare
ahcorde
pushed a commit
to ahcorde/system_metrics_collector
that referenced
this pull request
Dec 11, 2019
* initial commit * Process memory Measurement working Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Implement publish method Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Update implementation with interface changes Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add implementation file Add test file Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Revert local testing change (lint failure) Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Address review comments * Address outstanding review comments * Address minor review comments Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to measure the process memory (percentage used) by extending a PeriodicMeasurementNode. See https://github.com/ros-security/aws-roadmap/issues/139 for details.