Remove clear_measurements_on_publish

[mm318]

As alluded to at #16 (comment), this change removes the clear_measurements_on_publish argument from PeriodicMeasurementNode, treating it as if it was always true.

[thomas-moulard]

mainly LGTM, would be nice to clean the time constants a bit before merging

[thomas-moulard]

adding a comment to explain why this value is OK would be helpful, not sure if I understand very well what all those constants mean, and why this is safe and this test won't be flaky.

[thomas-moulard]

also, it's unclear what's the value here there. Once every 10ms, 10 seconds? INFREQUENT is not really helpful in this context.

[mm318]

@thomas-moulard and @dabonnie, can you take a look again?

[thomas-moulard]

Thanks @mm318 - before merging could you run this with --gtest_repeat=100000 to make sure it's not flaky?

[mm318]

I was able to repeat the test 14000+ times without fail before running into some unrelated RTPS error (like this aliasrobotics/aztarna#41)...

I am confident that the test is not flaky, as we should absolutely not see any publishing if the publishing period is set to twice that of the entire allotted test duration, even at the millisecond scale.

If we do see some publishing occur given this much margin (of the entire test duration), I would be concerned about the ROS2 executor.

[codecov]

Codecov Report

Merging #31 into master will decrease coverage by 0.37%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   42.04%   41.66%   -0.38%     
==========================================
  Files          26       26              
  Lines         880      876       -4     
  Branches      506      504       -2     
==========================================
- Hits          370      365       -5     
- Misses         50       52       +2     
+ Partials      460      459       -1

Flag	Coverage Δ
#unittests	41.66% <66.66%> (-0.38%)	⬇️

Impacted Files	Coverage Δ
...em_metrics_collector/periodic_measurement_node.hpp	100% <ø> (ø)	⬆️
...trics_collector/test_periodic_measurement_node.cpp	35.71% <100%> (-5.67%)	⬇️
...em_metrics_collector/periodic_measurement_node.cpp	44.68% <50%> (-0.22%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9391954...1e25c44. Read the comment docs.