Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Install system metrics collector lib and executable #34

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 10, 2019

Install system metrics collector lib and executable

@dabonnie
Copy link
Contributor

Hey @ahcorde.

Thanks for the PR! However, since we're currently in active development we'd prefer to have our headers private until we finalize our API. We can review this in next week's ROS2 Tooling Working Group and, if you're curious, you can see our team roadmap here: https://app.zenhub.com/workspaces/aws-robotics-open-source-roadmap-5d9662bf4e1ec400011c53c6/board?repos=212657172

@thomas-moulard
Copy link
Member

thomas-moulard commented Dec 10, 2019

Thanks for the contribution @ahcorde! 🎉

The part where you install the binary and lib SGTM. As @dabonnie mentionned, let's keep the headers private for now, we should never have to install those.

@ahcorde ahcorde force-pushed the ahcorde/install_system_metrics_collector branch from 097c49a to 26d37a6 Compare December 10, 2019 20:33
@ahcorde
Copy link
Contributor Author

ahcorde commented Dec 10, 2019

Hi everyone!

Done, I pushed only the installation.

I was trying to use you library in an external executable. I will be watching you repository for futures updates. Let me know if can help with something

@thomas-moulard thomas-moulard merged commit fc5f597 into ros-tooling:master Dec 10, 2019
@thomas-moulard
Copy link
Member

Merged, thanks a lot for the quick turn around on this PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants