Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Move private constants to .cpp file #39

Merged
merged 1 commit into from Dec 11, 2019
Merged

Move private constants to .cpp file #39

merged 1 commit into from Dec 11, 2019

Conversation

mm318
Copy link
Member

@mm318 mm318 commented Dec 11, 2019

Move what seems to be private constants from the .hpp header file to the .cpp file. This makes it more consistent with the other measurement nodes.

@mm318 mm318 requested a review from dabonnie December 11, 2019 07:42
Copy link
Member

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Current implementation is wrong indeed, as it duplicates symbols in each compilation unit.

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   42.04%   42.04%           
=======================================
  Files          26       26           
  Lines         880      880           
  Branches      506      506           
=======================================
  Hits          370      370           
  Misses         50       50           
  Partials      460      460
Flag Coverage Δ
#unittests 42.04% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ollector/linux_process_memory_measurement_node.cpp 33.33% <ø> (ø) ⬆️
...ollector/linux_process_memory_measurement_node.hpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9391954...a5d0d47. Read the comment docs.

@mm318 mm318 merged commit cf9bb2f into master Dec 11, 2019
@mm318 mm318 deleted the miaofei/move-consts branch December 11, 2019 08:22
ahcorde pushed a commit to ahcorde/system_metrics_collector that referenced this pull request Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants