Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Refactor CPU measurement utilities and tests #45

Merged
merged 1 commit into from Dec 19, 2019

Conversation

mm318
Copy link
Member

@mm318 mm318 commented Dec 19, 2019

This is a refactoring of functions and tests related to system CPU usage measurement, moving some of them to a common area to be shared by process CPU usage measurement later.

@mm318 mm318 requested a review from dabonnie December 19, 2019 20:59
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #45 into master will increase coverage by 0.03%.
The diff coverage is 24%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #45      +/-   ##
=========================================
+ Coverage   41.66%   41.7%   +0.03%     
=========================================
  Files          27      28       +1     
  Lines         876     880       +4     
  Branches      504     506       +2     
=========================================
+ Hits          365     367       +2     
  Misses         52      52              
- Partials      459     461       +2
Flag Coverage Δ
#unittests 41.7% <24%> (+0.03%) ⬆️
Impacted Files Coverage Δ
...m_metrics_collector/linux_cpu_measurement_node.cpp 34.61% <ø> (-2.12%) ⬇️
...m_metrics_collector/linux_cpu_measurement_node.hpp 100% <ø> (ø) ⬆️
...m_metrics_collector/test_linux_cpu_measurement.cpp 28.8% <0%> (+2.71%) ⬆️
...r/test/system_metrics_collector/test_utilities.cpp 14.89% <17.64%> (+0.6%) ⬆️
...r/test/system_metrics_collector/test_utilities.hpp 25% <25%> (ø)
...llector/src/system_metrics_collector/utilities.cpp 33.8% <42.3%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f269f...f1d3855. Read the comment docs.

@mm318 mm318 merged commit d24b001 into master Dec 19, 2019
@mm318 mm318 deleted the miaofei/measure-cpu-refactor branch December 19, 2019 23:08
Copy link
Member

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants