This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Add new package to view system metric data #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
mm318
reviewed
Dec 19, 2019
| @@ -59,7 +59,7 @@ int main(int argc, char ** argv) | |||
| std::make_shared<system_metrics_collector::LinuxProcessMemoryMeasurementNode>( | |||
| "linuxProcessMemoryCollector", | |||
| 1000ms, | |||
| "not_publishing_yet", | |||
| STATISTICS_TOPIC_NAME, | |||
There was a problem hiding this comment.
This system metric viewer will receive process metrics as well and filter them out?
There was a problem hiding this comment.
That's my current plan, yes. The viewing problem can be split into the following:
1). Logging the data into a parseable format for a display tool
2). Parse the logged data
3). Plot the data
mm318
approved these changes
Dec 19, 2019
zmichaels11
approved these changes
Dec 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 41.66% 41.66%
=======================================
Files 27 27
Lines 876 876
Branches 504 504
=======================================
Hits 365 365
Misses 52 52
Partials 459 459
Continue to review full report at Codecov.
|
mm318
pushed a commit
that referenced
this pull request
Dec 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the files generated by ros2 pkg create for a python project.