Follow ROS2 Style Guide

[dabonnie]

Description

Many constants defined in this project do not follow the guidelines for ROS2 Development. These should be respected.

Expected Behavior

Constants following style guide naming convention.

Actual Behavior

Constant naming does not follow the style guide naming convention.

[dabonnie]

Opened #51

[mm318]

There's more to this than just the names of the constants.

[thomas-moulard]

@mm318 Could you list what you think is missing from this ticket? This will make your comment actionable.

[mm318]

The other issues that are immediately noticeable are:

• Function names need to UpperCamelCase
• Class member variables need to be suffixed with _

These are being addressed in #53.

[mm318]

Also found that some class and function comments start with a noun (a subject) or with a singular verb (imperative mood) and do not end with proper punctuation (a period).

Looking at the examples, it seems like both class and function comments should be in the indicative mood without a subject (the subject is implied to be the class or function that the comment is for) with proper punctuation.

[dabonnie]

Closed via #51 and #56