Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Follow variable naming conventions of ROS2 style guide #56

Merged
merged 2 commits into from Dec 27, 2019

Conversation

mm318
Copy link
Member

@mm318 mm318 commented Dec 24, 2019

For addressing the remaining issues in and closing out #50.

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 28.22%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #56   +/-   ##
======================================
  Coverage    41.7%   41.7%           
======================================
  Files          28      28           
  Lines         880     880           
  Branches      506     506           
======================================
  Hits          367     367           
  Misses         52      52           
  Partials      461     461
Flag Coverage Δ
#unittests 41.7% <28.22%> (ø) ⬆️
Impacted Files Coverage Δ
...llector/src/system_metrics_collector/collector.hpp 100% <ø> (ø) ⬆️
...llector/src/system_metrics_collector/collector.cpp 62.06% <0%> (ø) ⬆️
...em_metrics_collector/metrics_message_publisher.cpp 65.21% <0%> (ø) ⬆️
...r/src/moving_average_statistics/moving_average.hpp 100% <100%> (ø) ⬆️
...r/test/system_metrics_collector/test_collector.cpp 43.24% <20%> (ø) ⬆️
...etrics_collector/test_linux_memory_measurement.cpp 30.7% <23.4%> (ø) ⬆️
...m_metrics_collector/test_linux_cpu_measurement.cpp 28.8% <24.24%> (ø) ⬆️
...tor/test_linux_process_memory_measurement_node.cpp 41.93% <28.57%> (ø) ⬆️
...trics_collector/test_periodic_measurement_node.cpp 35.71% <31.57%> (ø) ⬆️
...rage_statistics/test_moving_average_statistics.cpp 59.22% <37.93%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579d3f4...8b61b35. Read the comment docs.

@zmichaels11 zmichaels11 self-requested a review December 26, 2019 23:49
@mm318 mm318 merged commit e8bcb98 into master Dec 27, 2019
@mm318 mm318 deleted the miaofei/style-guide-variables branch December 27, 2019 02:05
mm318 added a commit that referenced this pull request Dec 27, 2019
* update variable names to fit ROS2 style guide

* revert local variable name change
@dabonnie dabonnie mentioned this pull request Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants