This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Add periodic API #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update cmake to build
dabonnie
requested review from
prajakta-gokhale,
thomas-moulard and
zmichaels11
There was a problem hiding this comment.
PTAL before continuing with this design:
- High Integrity C++ standard - rule 3.13 Do not use std::recursive mutex
- Recursive mutexes by David Butenhof on comp.programming.threads
- std::mutex vs std::recursive_mutex as class member
system_metrics_collector/src/system_metrics_collector/collector.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/collector.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/collector.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.hpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
zmichaels11
approved these changes
Nov 7, 2019
- Remove recursive mutex - simplify collector and measurement design
|
Pushed changes addressing design, but will add thread safety annotations in this PR. |
zmichaels11
reviewed
Nov 7, 2019
system_metrics_collector/src/system_metrics_collector/collector.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/src/system_metrics_collector/collector.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/test/system_metrics_collector/test_periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/test/system_metrics_collector/test_periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
Add thread safety annotations
thomas-moulard
approved these changes
Nov 8, 2019
zmichaels11
approved these changes
Nov 8, 2019
system_metrics_collector/test/system_metrics_collector/test_periodic_measurement_node.cpp
Outdated
Show resolved
Hide resolved
system_metrics_collector/test/system_metrics_collector/test_periodic_measurement_node.cpp
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add relevant class and abstractions to perform periodic measurements.
Note: the Collector and Periodic patter follows previous work from ROS CloudWatch CEs and ROS2 QoS System tests.