Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Add example launch file #81

Merged
merged 10 commits into from Jan 24, 2020
Merged

Add example launch file #81

merged 10 commits into from Jan 24, 2020

Conversation

dabonnie
Copy link
Contributor

@dabonnie dabonnie commented Jan 23, 2020

Add a new launch file for composable nodes. The purpose is to demo measuring a ROS2 process's CPu and memory usage.

Signed-off-by: Devin Bonnie dbbonnie@amazon.com

@thomas-moulard
Copy link
Member

thomas-moulard commented Jan 23, 2020

This seems to have a lot of overhead compared to having a simple subdirectory - what is the intent?

@dabonnie
Copy link
Contributor Author

This seems to have a lot of overhead compared to having a simple subdirectory - what is the intent?

Do you mean overhead from the package requirements? If so this is done so the examples, via the current README, can be run by only building the system_metrics_collector_examples package. I found this to be useful when building using packages-up-to.

Also note that I intend to add another launch file, but as a separate PR to reduce scope here.

@dabonnie
Copy link
Contributor Author

This seems to have a lot of overhead compared to having a simple subdirectory - what is the intent?

Do you mean overhead from the package requirements? If so this is done so the examples, via the current README, can be run by only building the system_metrics_collector_examples package. I found this to be useful when building using packages-up-to.

Also note that I intend to add another launch file, but as a separate PR to reduce scope here.

Per offline discussion with @thomas-moulard: I'll modify this PR to simply add a new directory but not a new package. This reduces the amount of boilerplate to maintain.

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Automatically configure and start composable nodes

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie dabonnie changed the title Add examples package Add example launch file Jan 23, 2020
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes!

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #81 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage    39.3%   39.24%   -0.06%     
==========================================
  Files          33       33              
  Lines        1346     1348       +2     
  Branches      809      811       +2     
==========================================
  Hits          529      529              
  Misses         62       62              
- Partials      755      757       +2
Flag Coverage Δ
#unittests 39.24% <0%> (-0.06%) ⬇️
Impacted Files Coverage Δ
...ollector/linux_process_memory_measurement_node.cpp 35.71% <0%> (-1.33%) ⬇️
...s_collector/linux_process_cpu_measurement_node.cpp 61.9% <0%> (-3.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c66c4...b78189e. Read the comment docs.

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Copy link
Member

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM - minor nits

system_metrics_collector/package.xml Outdated Show resolved Hide resolved
@thomas-moulard
Copy link
Member

Check also whether you'd like to install examples or not. That would need you to update the CMakeListst.txt

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie dabonnie merged commit 017a054 into master Jan 24, 2020
@dabonnie dabonnie deleted the dabonnie/examples branch January 24, 2020 01:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants