Conversation
This seems to have a lot of overhead compared to having a simple subdirectory - what is the intent? |
Do you mean overhead from the package requirements? If so this is done so the examples, via the current README, can be run by only building the system_metrics_collector_examples package. I found this to be useful when building using Also note that I intend to add another launch file, but as a separate PR to reduce scope here. |
Per offline discussion with @thomas-moulard: I'll modify this PR to simply add a new directory but not a new package. This reduces the amount of boilerplate to maintain. |
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Automatically configure and start composable nodes Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
72671fa
to
8c77727
Compare
system_metrics_collector/src/system_metrics_collector/linux_process_cpu_measurement_node.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the changes!
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 39.3% 39.24% -0.06%
==========================================
Files 33 33
Lines 1346 1348 +2
Branches 809 811 +2
==========================================
Hits 529 529
Misses 62 62
- Partials 755 757 +2
Continue to review full report at Codecov.
|
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM - minor nits
system_metrics_collector/launch/talker_listener_example.launch.py
Outdated
Show resolved
Hide resolved
system_metrics_collector/launch/talker_listener_example.launch.py
Outdated
Show resolved
Hide resolved
Check also whether you'd like to install examples or not. That would need you to update the CMakeListst.txt |
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Add a new launch file for composable nodes. The purpose is to demo measuring a ROS2 process's CPu and memory usage.
Signed-off-by: Devin Bonnie dbbonnie@amazon.com