Add e2e test

[dabonnie]

Adds an e2e test to launch and verify functionality.

[codecov]

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   39.44%   39.44%           
=======================================
  Files          33       33           
  Lines        1374     1374           
  Branches      822      822           
=======================================
  Hits          542      542           
  Misses         65       65           
  Partials      767      767

Flag	Coverage Δ
#unittests	39.44% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf4e92...0b156b9. Read the comment docs.

[piraka9011]

Does codecov consider this e2e test at all?

[piraka9011]

The tests currently fail immediately by raising an exception. Do we want to still run the rest of the tests even if one fails.

[thomas-moulard]

Thank you very much Devin for taking the time to write this e2e test, this will immensely useful.

Could you have a pass on my comments? I'd like to secure it to make sure it does not become flaky, and a maintenance burden to the team. Generally, the structure and the idea LGTM (it could probably even be generalized and used in multiple projects!)

[thomas-moulard]

A link on why negative if-s are not prefered: https://schneide.blog/2014/08/03/dont-ever-not-avoid-negative-logic/ :)

[dabonnie]

The tests currently fail immediately by raising an exception. Do we want to still run the rest of the tests even if one fails.

The tests are structured in order to fast fail. For example, if a node doesn't enumerate or if the lifecycle nodes are inactive, then the publisher test will ultimately fail.

[dabonnie]

Note for the reviewers: there are a few unresolved comments that I am still implementing.

[dabonnie]

Note for the reviewers: there are a few unresolved comments that I am still implementing.

This is ready for re-review.

[piraka9011]

It looks you addressed most of the outstanding comments offline so LGTM