Fixed C++20 warning that ‘++’ expression of ‘volatile’-qualified type is deprecated #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't seem volatile is helping with multithreading, as two separate threads could be calling |
|
CI:
|
… is deprecated Signed-off-by: Guilherme Rodrigues <guilherme.rodrigues@ait.ac.at>
AiVerisimilitude
force-pushed
the
volatile_fix
branch
from
2728c3d
to
0e82a4f
Compare
|
Alright. Then I've kept it simple :) Thanks for the review! |
|
Correct CI:
|
|
Finally with correct repos
|
quarkytale
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the intention here with this specific volatile use is, but I assume it was to account for a multithreaded environment?
If so, I replace the volatile with std::atomic which is better suited in this PR. Otherwise, I can just remove the volatile qualifier.