Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in rqt_dep #41

Closed
wants to merge 1 commit into from

Conversation

vrabaud
Copy link

@vrabaud vrabaud commented May 16, 2014

This fixes an old bad search/replace: set_color was renamed for this qt_dotgraph objects, but on that line it's a normal Pydot object.

This fixes an old bad search/replace: set_color was renamed for this qt_dotgraph objects, but on that line it's a normal Pydot object.
@tfoote tfoote added the bug label May 20, 2014
@tfoote
Copy link

tfoote commented May 20, 2014

+1 just ran into this too. rqt_dep is not useable.without htis.

@ablasdel
Copy link

+1 this fix makes it work for me too.

@dirk-thomas
Copy link
Contributor

Regression of #40.

Just by reading the diff I would assume that the following two changes are also wrong:

Can someone please confirm this by running the code in question? And update this PR if applicable?

@tfoote
Copy link

tfoote commented May 20, 2014

I cannot test that code path easily as it's only for dry stacks that clusters are generated. And on my saucy machine I don' thave convenient dry stacks. But from reading the code those lines should be changed too. They won't cause crashes due to the if clause, but I would suggest changing those lines too.

I've tested with and without the extra two lines changes and experienced no crashes or errors (wet only)

@dirk-thomas dirk-thomas self-assigned this May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants