Add checkbox group for settings dialogs #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,71 @@ | |||
| # Software License Agreement (BSD License) | |||
| # | |||
| # Copyright (c) 2012, Dorian Scholz | |||
There was a problem hiding this comment.
Do you want to update the copyright information?
There was a problem hiding this comment.
Thanks, I updated the info and changelog.
|
|
||
| class CheckBoxGroup(QGroupBox): | ||
|
|
||
| def __init__(self, options, title='Checkboxes', selected_indexes=[]): |
There was a problem hiding this comment.
Please add a docblock for this - especially to document what kind of information can be passed in as options.
… argument to add options directly to parent widget
|
Squashed and merged in f4bda27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the class CheckBoxGroup to qt_gui_py_common for use in the SimpleSettingsDialog class. Options are not exclusive and return an array of selected indexes and selected options when polled using the get_settings function.
This class will be used to add optional plotting markers to rqt_plot and the rqt_bag plotting plugin.