Reacting on errors happening while loading a bag #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lename in messages, change some warnings to info messages
|
Thank you for the improvement. I made some small changes:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The widget uses the functionalities of the Bag class without catching the eventual exceptions that could be raised due to faulty bags.
If this happens the exception was raised up to the terminal where the traceback was printed.
In the GUI on the other hand no indication was of an error was printed and "Loading" would have stayed in the status bar indefinitely.
The added code block outputs the information about the cause of the error to the status bar and the terminal.