Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the package.xml files with the latest Open Robotics maintainers #58

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

mjeronimo
Copy link
Contributor

@mjeronimo mjeronimo commented Oct 6, 2020

See title :)

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

@dirk-thomas
Copy link
Contributor

I think it is safe to assume that neither Aaron nor Austin are actually maintaining the packages in this repository.

Please remove both as well as me as maintainer but add all three as authors.

@dirk-thomas
Copy link
Contributor

@mjeronimo
Copy link
Contributor Author

mjeronimo commented Oct 6, 2020

@dirk-thomas Would you prefer <author>s with or without e-mail addresses? Also, stylistically, are we blocking sections or removing blank lines?

@dirk-thomas
Copy link
Contributor

Would you prefer s with or without e-mail addresses?

I don't mind either way.

Also, stylistically, are we blocking sections or removing blank lines?

We don't have a consistent style I think. I usually try to make sure that the different dependency types are blocks but all the other metainfo can be without empty line (or keep them as is).

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
@mjeronimo mjeronimo merged commit 928c518 into master Oct 7, 2020
@mjeronimo mjeronimo deleted the mjeronimo/update-maintainers branch October 8, 2020 18:28
mjeronimo added a commit that referenced this pull request Oct 14, 2020
#58)

* Update the package.xml files with the latest Open Robotics maintainers
* Add <author> tag to acknowledge previous maintainer
* Move previous maintainers to authors. Reorder fields per schema
* Restore author accidentally deleted in previous check-in

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants