Fix a bug with the status line progress bar #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a bag with lots of topics, the progress bar was not getting reset to 0 after the load completed. This was due to the 'updated' flag getting overwritten in the index caching thread and not properly detecting that something had changed with the timeline. If the last topic evaluated had no entries then it was erroneously assumed that nothing at all had changed (for any topic). Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
dirk-thomas
approved these changes
Oct 9, 2020
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a bag with lots of topics, the progress bar was not
getting reset to 0 after the load completed. This was due to the
'updated' flag getting overwritten in the index caching thread and
not properly detecting that something had changed with the timeline.
If the last topic evaluated had no entries then it was erroneously
assumed that nothing at all had changed (for any topic).
Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org