rqt_bag) topics with long names break the layout

[130s]

$ roslaunch pr2_moveit_tutorials planning_pipeline_tutorial.launch

On another terminal,

n@rosquid-serval:~/link/ROS/hydro_precise/catkinws_rqt_dev$ ps awx|grep rqt
15938 pts/2    S+     0:00 grep --color=auto rqt
[1]+  Done                    rqt
nrosquid@rosquid-serval:~/link/ROS/hydro_precise/catkinws_rqt_dev$ rqt &

When click the "red circle" to start bagging,

nrosquid@rosquid-serval:~/link/ROS/hydro_precise/catkinws_rqt_dev$ [INFO] [WallTime: 1375783546.249167] Recording to /home/nrosquid/Desktop/testes_2013-08-06-04-59-46_2013-08-06-05-05-46.bag.
Traceback (most recent call last):
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 270, in paint
    self._draw_topic_dividers(painter)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 444, in _draw_topic_dividers
    (x, y, w, h) = self._history_bounds[topic]
KeyError: '/rviz_rosquid_serval_14596_8880025419441022858/motionplanning_planning_scene_monitor/parameter_descriptions'
Traceback (most recent call last):
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 273, in paint
    self._draw_topic_histories(painter)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 337, in _draw_topic_histories
    self._draw_topic_history(painter, topic)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 362, in _draw_topic_history
    msg_combine_interval = self.map_dx_to_dstamp(self._default_msg_combine_px)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 847, in map_dx_to_dstamp
    return float(dx) * (self._stamp_right - self._stamp_left) / self._history_width
ZeroDivisionError: float division by zero
Traceback (most recent call last):
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 273, in paint
    self._draw_topic_histories(painter)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 337, in _draw_topic_histories
    self._draw_topic_history(painter, topic)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 362, in _draw_topic_history
    msg_combine_interval = self.map_dx_to_dstamp(self._default_msg_combine_px)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 847, in map_dx_to_dstamp
    return float(dx) * (self._stamp_right - self._stamp_left) / self._history_width
ZeroDivisionError: float division by zero
Traceback (most recent call last):
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 273, in paint
    self._draw_topic_histories(painter)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 337, in _draw_topic_histories
    self._draw_topic_history(painter, topic)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 362, in _draw_topic_history
    msg_combine_interval = self.map_dx_to_dstamp(self._default_msg_combine_px)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 847, in map_dx_to_dstamp
    return float(dx) * (self._stamp_right - self._stamp_left) / self._history_width
ZeroDivisionError: float division by zero
Traceback (most recent call last):
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 273, in paint
    self._draw_topic_histories(painter)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 337, in _draw_topic_histories
    self._draw_topic_history(painter, topic)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 362, in _draw_topic_history
    msg_combine_interval = self.map_dx_to_dstamp(self._default_msg_combine_px)
  File "/home/nrosquid/hydro_precise/catkinws_rqt_dev/src/rqt_common_plugins/rqt_bag/src/rqt_bag/timeline_frame.py", line 847, in map_dx_to_dstamp
    return float(dx) * (self._stamp_right - self._stamp_left) / self._history_width
ZeroDivisionError: float division by zero
nrosquid@rosquid-serval:~/link/ROS/hydro_precise/catkinws_rqt_dev$ ps awx|grep rqt
16097 pts/2    S+     0:00 grep --color=auto rqt
[1]+  Done                    rqt
nrosquid@rosquid-serval:~/link/ROS/hydro_precise/catkinws_rqt_dev$ 

ros-groovy-rqt-gui 0.2.9-0precise-20130721-1934-+0000
ros-groovy-rqt-bag 0.2.17-0precise-20130721-2209-+0000

[ablasdel]

I have changed this from enhancement to bug since rqt_bag is unusable when the names get too long.

the enhancement suggested here might elevate suffering: #11

Otherwise it might be a good solution to "abbreviate" long topic names in some way and have the full name viewable with mouse over.

[ablasdel]

@130s would you mind sending me the bag file that you were running in that screenshot?

[130s]

I put a .bag file to https://github.com/130s/rqt_common_plugins/tree/add_bagfile_to_testDir/rqt_bag/test

[ablasdel]

Ok the quick fix I have "works" on this but I want to make it more descriptive/adaptable. I'll lookinto adding mouse over next.

[ablasdel]

This turned out looking pretty good. The topic name auto sizes to the space available. (at the moment I limit the topic area to a max of 25% of the view-able area. This could be adjusted to taste but seemed a good balance)

At the moment I think I will forgo the popups with the full name since this worked out so nicely and the right click/view by topic gives you a way to view them anyway.

I will clean it up and pull it.

One thing I do notice. The last bit of the topic name is probably the most important. I think I might make it so that that portion is never trimmed or at least trimmed later than most.

[130s]

dd6f42d works nicely!