rqt_bag: publish clock time from bag #204
Conversation
| @@ -85,16 +109,18 @@ def message_viewed(self, bag, msg_data): | |||
| if self.timeline.play_speed <= 0.0: | |||
| return | |||
|
|
|||
| topic, msg, _ = msg_data | |||
| topic, msg, t = msg_data | |||
There was a problem hiding this comment.
please avoid single letter variable names, calling it "time" or "clock" would be better than "t"
|
@dirk-thomas @130s @ablasdel |
| @@ -494,6 +495,8 @@ def _create_player(self): | |||
| if not self._player: | |||
| try: | |||
| self._player = Player(self) | |||
| if(self._publish_clock): | |||
There was a problem hiding this comment.
Please remove the parenthesis around the condition.
|
@dirk-thomas Thanks for the comments, I hope I have addressed them adequately. I'm not sure if I interpreted your last comment on the exception handling correct, if not let me know. |
| @@ -22,6 +22,7 @@ | |||
| <run_depend>rospy</run_depend> | |||
| <run_depend version_gte="0.2.12">rqt_gui</run_depend> | |||
| <run_depend>rqt_gui_py</run_depend> | |||
| <run_depend>rosgraph_msgs</run_depend> | |||
There was a problem hiding this comment.
Sorry to being overly picky - can you please move this run dependency to be in alphabetical order of the other run dependencies. That makes it much easier to find stuff especially when the list grow over time.
|
Thanks for doing the changes so promptly. After you have addressed the last comment (run_depend order) can you please also squash your commits into a single one? After that I will happily merge the pull request. |
rqt_bag: publish clock time from bag
|
It does not work also for me. I can see the suggested option on the help command, but then if I run it it does not publish. I have Indigo and I installed the packages through apt-get on Ubuntu 14.04 |
|
Works for me on Indigo, if I
|
These changes address Issue #102: rqt_bag: missing clock publisher.