Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(rqt_console) (nice-to-have) move filtering classes to common pkgs #30

Closed
130s opened this issue Feb 7, 2013 · 7 comments
Closed

(rqt_console) (nice-to-have) move filtering classes to common pkgs #30

130s opened this issue Feb 7, 2013 · 7 comments

Comments

@130s
Copy link
Member

130s commented Feb 7, 2013

I know it wasn't intended when rqt_console was initially written to make all those filter classes to be generic. But it would be very beneficial to have a set of filtering components that provide multiple types of filters and users can select / de-select them on GUI while system aggregates the result from all selected filters (like rqt_console does).

@130s
Copy link
Member Author

130s commented Feb 7, 2013

I'm writing filtering function (for this enhancement) and noticed that one tiny detail that prohibits generalization is MessageFilter hardcodes the type of regex as exact-match (actual code is here). I'd rather use indexIn. It'd be nice to be able to select matching type.

@dirk-thomas
Copy link
Contributor

Could you elaborate a bit more what the issue currently is and how that should to be improved? Based on the issue title, the two comments and the referenced other issue I can not comprehend what this issue is about.

@130s
Copy link
Member Author

130s commented Feb 8, 2013

This is an enhancement, not an issue.

I found that the filtering feature that rqt_console has is generic and useful (although it might have not been intended to be used from other pkgs). I'm suggesting to make its API generic.

Nevermind the issue I referenced in the 1st comment.

@ablasdel
Copy link
Contributor

ablasdel commented Sep 2, 2013

I think the filter funtionality is very specific in console.

What other plugin would you consider adding such an elaborate filter to?

Unless we can define what would need it I think it would be best to close this as wont fix.

@130s
Copy link
Member Author

130s commented Sep 3, 2013

I don't have time to look at carefully but I thought I made rqt_reconfigure depend on console, or at least copy-paste its code to realize filtering.

(Isn't making general API good idea in general btw? )

@ablasdel
Copy link
Contributor

ablasdel commented Sep 3, 2013

Yes it is I just didn't see anywhere someone would want to use it. If you used it in rqt reconfigure I'm all for moving it out at some point for reduced code duplication. But as you said low priority.

@dirk-thomas
Copy link
Contributor

This issue was moved to ros-visualization/rqt_console#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants