Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exclude by message(s) #11

Merged
merged 1 commit into from Jan 14, 2020

Conversation

LeroyR
Copy link
Contributor

@LeroyR LeroyR commented Aug 13, 2019

Calculation of the text cell was all wrong.
Also there are 7 cells per row (id# is cell 0)

@dirk-thomas
Copy link
Contributor

Please describe the steps to reproduce what wasn't working without this patch and works with this patch.

@LeroyR
Copy link
Contributor Author

LeroyR commented Dec 9, 2019

From memory:

  1. "Exclude by Message" creates regex filter using the message string but does not escape anything. Finding cases where this breaks is an exercise left for the reader of this comment.
  2. Selecting multiple messages and creating filters for them results in garbage filters as the wrong column gets selected as input beyond the first.

Steps to reproduce:

  1. Select Multiple Rows
  2. Right Click -> Exclude by Message
  3. Look at the Filters

@dirk-thomas
Copy link
Contributor

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 602baa7 into ros-visualization:master Jan 14, 2020
dirk-thomas pushed a commit that referenced this pull request Jan 14, 2020
@dirk-thomas
Copy link
Contributor

Cherry-picked to the dashing-devel branch: 76ecf1b.

This was referenced Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants