ros kinetic qt5 compatibility fix #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue #107 |
| @@ -48,6 +48,8 @@ class MonitorDashWidget(IconToolButton): | |||
| :param context: The plugin context to create the monitor in. | |||
| :type context: qt_gui.plugin_context.PluginContext | |||
| """ | |||
| msg_trigger = pyqtSignal() | |||
There was a problem hiding this comment.
Please use the generic Signal instead of PyQt specific pyqtSignal.
There was a problem hiding this comment.
Since the signal shouldn't be used externally it should also be prefixed with an underscore to make it "private".
|
fixed |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.