Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique name for axtools title bar #107

Merged
merged 3 commits into from
Aug 5, 2018

Conversation

fmessmer
Copy link
Contributor

@fmessmer fmessmer commented Jun 8, 2018

when using the axclient with multiple actions (different action_names, but same action_type), it's impossible to determine which GUI Client corresponds to which ActionServer

thus, I added the action_name as part of the title bar caption (the - is just for nicer visualization)
I did the same for the axserver for consistency

hope this gets merged and released for Kinetic and onwards

@fmessmer
Copy link
Contributor Author

fmessmer commented Jun 8, 2018

I doubt the failing test has anything to do with my contribution

@fmessmer
Copy link
Contributor Author

@mikaelarguedas
friendly ping - do you think this could get merged and released into Indigo/Kinetic and later distros?

@fmessmer
Copy link
Contributor Author

fmessmer commented Jul 21, 2018

@mikaelarguedas
any chance this gets merged? and released?

@mikaelarguedas
Copy link
Member

@fmessmer sorry for the delay. I've been unable to find time for ROS 1 maintenance recently. I'll find some time this week to review pending PRs.

Thanks for your patience and contributions!

@mikaelarguedas
Copy link
Member

I usually hold on non critical bug fixes for stable distros (especially the "ABI breaking" ones).
As this is python code and a gui tool without much change of regression, it should be fine. So I'll merge and release this on all distros before branching out.

Thanks for the patch !

@mikaelarguedas mikaelarguedas merged commit f1f6f9b into ros:indigo-devel Aug 5, 2018
@fmessmer fmessmer deleted the unique_names_axtools branch February 18, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants