Improved the const-correctness of some actionlib classes. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBlakeAnderson
force-pushed
the
indigo-devel
branch
from
aa7870b
to
a47b10d
Compare
|
Looks like the checks are failing simply because the check server is running too slowly. Not sure what I can do about that. |
|
The Kinetic failure was there before and is not impacted by this PR. I wanted to fix it before merging others PRs but I think we shouldn't delay more fixes/cleanup PRs for the sake of this flaky test. Thanks for your patience and contribution. |
|
@ros-pull-request-builder retest this please |
|
merging this now that tests are passing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved the const-correctness of certain classes. This was motivated by a need to call SimpleActionClient::getResult() and SimpleActionClient::getState() inside a const method on my end.
More improvement can probably be done in this area, however I did enough to fix my specific issue.