Fix datarace in ActionClient::initClient() #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with original
…onitor - bugfix : connection_monitor should wait for result
mikaelarguedas
approved these changes
Mar 19, 2017
There was a problem hiding this comment.
Hi @1r0b1n0, Sorry for dropping the ball on this.
The change looks good to me, nice catch for the wrong callback used in the ConnectionMonitor.
I tried to reproduce the issue without this change but didn't see any failure in about 3000 runs. It doesn't change the fact that this change is an improvement and I will get it in the next release.
Thanks for your contribution!
|
@ros-pull-request-builder retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1] ConnectionMonitor should only be initialized when ros::Time::now is valid (can only happen when using gazebo)
2] ConnectionMonitor didn't wait for the action/result topic. In some rare cases the action_client could stay stuck in the WAITING_FOR_RESULT state because the goal was sent before ROS connected to the the server's result topic